Skip to content

add default channel config value load from root config value#66

Merged
lalepee merged 4 commits intomainfrom
LAL/PROD-15623_simplify_coal-config.toml
Mar 17, 2026
Merged

add default channel config value load from root config value#66
lalepee merged 4 commits intomainfrom
LAL/PROD-15623_simplify_coal-config.toml

Conversation

@lalepee
Copy link
Collaborator

@lalepee lalepee commented Mar 11, 2026

No description provided.

@lalepee lalepee requested a review from neomatamune March 11, 2026 15:40
@lalepee lalepee force-pushed the LAL/PROD-15623_simplify_coal-config.toml branch from b1fdd4b to bab6441 Compare March 11, 2026 15:54
Copy link
Member

@neomatamune neomatamune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Print in tests is bad m'kay

channel.required_keys = {"section1": ["key1", "key2"], "section2": ["key3"]}
channel.configuration = {"section1": {"key1": "value1"}, "section2": {"key3": "value3"}} # missing key2

print(type(channel.configuration))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove that print :P

@lalepee lalepee requested a review from neomatamune March 13, 2026 14:31
@lalepee lalepee merged commit e73541a into main Mar 17, 2026
7 checks passed
@lalepee lalepee deleted the LAL/PROD-15623_simplify_coal-config.toml branch March 17, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants